-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pypi trusted publisher #1447
base: master
Are you sure you want to change the base?
Conversation
Remove use of token, use Pypi OIDC from github. closes #1331 Signed-off-by: Alexandre Lavigne <[email protected]>
Should I push an empty new release 6.1.1 in order to test the release workflow? If it does not work then we can revert for now and push a 6.1.2 🤔 |
We could use the test.pypi? and you can make a release but tag it as |
we could, it makes me think about something that could be useful:
To do that we can add some filters in the workflow, it can be based on the inputs and decide if this is a real release or not. What I have in mind is:
our tags are all formatted as: so we could filter:
meaning:
what do you think ? |
This sounds like a good idea to me. I tried to think of a time we would like to push a tag that is not |
you're right we never release 'alpha' or 'beta' or release-candidate versions. What I will do is:
|
28a227f
to
ba3a594
Compare
alright, that was a good test as it does not work, nice we could catch it before real release. may be @burnash knows, could you check please the settings you provided to Pypi just in case, when you get a chance ? matching with the workflow filename, the workflow name (which is different) and the env too ? thank you. |
Remove use of token, use Pypi OIDC from github.
closes #1331